// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "base/command_line.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/common/chrome_switches.h"

class WindowOpenPanelTest : public ExtensionApiTest {
  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
    ExtensionApiTest::SetUpCommandLine(command_line);
    command_line->AppendSwitch(switches::kEnablePanels);
  }
};

// http://crbug.com/162912 || defined(OS_WIN)
// http://crbug.com/253417 for NDEBUG
#if defined(OS_MACOSX) && defined(NDEBUG)
// Focus test fails if there is no window manager on Linux.
IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, WindowOpenFocus) {
  ASSERT_TRUE(RunExtensionTest("window_open/focus")) << message_;
}
#endif

// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "base/command_line.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/common/chrome_switches.h"

class WindowOpenPanelTest : public ExtensionApiTest {
  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
    ExtensionApiTest::SetUpCommandLine(command_line);
    command_line->AppendSwitch(switches::kEnablePanels);
  }
};

#if defined(OS_MACOSX)  // http://crbug.com/162912 || defined(OS_WIN)
// Focus test fails if there is no window manager on Linux.
IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, WindowOpenFocus) {
  ASSERT_TRUE(RunExtensionTest("window_open/focus")) << message_;
}
#endif

--- 
+++ 
@@ -13,7 +13,9 @@
   }
 };
 
-#if defined(OS_MACOSX)  // http://crbug.com/162912 || defined(OS_WIN)
+// http://crbug.com/162912 || defined(OS_WIN)
+// http://crbug.com/253417 for NDEBUG
+#if defined(OS_MACOSX) && defined(NDEBUG)
 // Focus test fails if there is no window manager on Linux.
 IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, WindowOpenFocus) {
   ASSERT_TRUE(RunExtensionTest("window_open/focus")) << message_;
Disable WindowOpenPanelTest.WindowOpenFocus on Mac debug builds.

This test is flaking very often and adding a lot of noise to the tree. It
consistently takes 44-45 secs on debug, while taking 4 secs on release.

TBR=jam@chromium.org
BUG=253417

Review URL: https://codereview.chromium.org/17634008

git-svn-id: de016e52bd170d2d4f2344f9bf92d50478b649e0@208478 0039d316-1c4b-4281-b951-d872f2087c98
