import SPELLS, { registerSpell } from 'common/SPELLS';
import Analyzer, { Options } from 'parser/core/Analyzer';
import Events, { Ability, AnyEvent } from 'parser/core/Events';

/**
 * We automatically discover spell info from the combat log so we can avoid many
 * calls to resolve missing spell info.
 */
class SpellInfo extends Analyzer {
  constructor(options: Options) {
    super(options);
    this.addEventListener(Events.any, this.onEvent);
  }

  onEvent(event: AnyEvent) {
    if ('ability' in event) {
      this.addSpellInfo(event.ability);
    }
    if ('extraAbility' in event) {
      this.addSpellInfo(event.extraAbility);
    }
  }

  addSpellInfo(ability: Omit<Ability, 'type'>) {
    if (SPELLS[ability.guid] || !ability.name || !ability.abilityIcon) {
      return;
    }

    registerSpell(ability.guid, ability.name, ability.abilityIcon.replace(/\.jpg$/, ''));
  }
}

export default SpellInfo;

import SPELLS, { registerSpell } from 'common/SPELLS';
import Analyzer, { Options } from 'parser/core/Analyzer';
import Events, { Ability, AnyEvent } from 'parser/core/Events';

/**
 * We automatically discover spell info from the combat log so we can avoid many
 * calls to resolve missing spell info.
 */
class SpellInfo extends Analyzer {
  constructor(options: Options) {
    super(options);
    this.addEventListener(Events.any, this.onEvent);
  }

  onEvent(event: AnyEvent) {
    if ('ability' in event) {
      this.addSpellInfo(event.ability);
    }
    if ('extraAbility' in event) {
      this.addSpellInfo(event.extraAbility);
    }
  }

  addSpellInfo(ability: Omit<Ability, 'type'>) {
    if (SPELLS[ability.guid]) {
      return;
    }

    registerSpell(ability.guid, ability.name, ability.abilityIcon.replace(/\.jpg$/, ''));
  }
}

export default SpellInfo;

--- 
+++ 
@@ -22,7 +22,7 @@
   }
 
   addSpellInfo(ability: Omit<Ability, 'type'>) {
-    if (SPELLS[ability.guid]) {
+    if (SPELLS[ability.guid] || !ability.name || !ability.abilityIcon) {
       return;
     }
 
Fix crash when ability object does not include name or icon
