package hmda.validation.rules.lar.validity

import hmda.model.fi.lar.LoanApplicationRegister
import hmda.validation.dsl.Result
import hmda.validation.rules.EditCheck
import scala.util.Try

object V470 extends EditCheck[LoanApplicationRegister] {

  def apply(lar: LoanApplicationRegister): Result = {
    val applicant = lar.applicant
    when(applicant.race1 is containedIn(1 to 5)) {
      (validRace(applicant.race2) is equalTo(true)) and
        (validRace(applicant.race3) is equalTo(true)) and
        (validRace(applicant.race4) is equalTo(true)) and
        (validRace(applicant.race5) is equalTo(true))
    }
  }

  private def validRace(input: String): Boolean = {
    (input == "") || inRange(1 to 5, input).getOrElse(false)
  }

  private def inRange(domain: Seq[Int], input: String): Try[Boolean] = {
    Try(domain.contains(input.toInt))
  }

  def name: String = "V470"

}

package hmda.validation.rules.lar.validity

import hmda.model.fi.lar.LoanApplicationRegister
import hmda.validation.dsl.Result
import hmda.validation.rules.EditCheck

object V470 extends EditCheck[LoanApplicationRegister] {

  def apply(lar: LoanApplicationRegister): Result = {
    val applicant = lar.applicant
    when(applicant.race1 is containedIn(1 to 5)) {
      (validRace(applicant.race2) is equalTo(true)) and
        (validRace(applicant.race3) is equalTo(true)) and
        (validRace(applicant.race4) is equalTo(true)) and
        (validRace(applicant.race5) is equalTo(true))
    }
  }

  private def validRace(input: String): Boolean = {
    (input == "") || inRange(1 to 5, input)
  }

  private def inRange(domain: Seq[Int], input: String): Boolean = {
    try {
      val x = input.toInt
      domain.contains(x)
    } catch {
      case ex: NumberFormatException => false
    }
  }

  def name: String = "V470"

}

--- 
+++ 
@@ -3,6 +3,7 @@
 import hmda.model.fi.lar.LoanApplicationRegister
 import hmda.validation.dsl.Result
 import hmda.validation.rules.EditCheck
+import scala.util.Try
 
 object V470 extends EditCheck[LoanApplicationRegister] {
 
@@ -17,16 +18,11 @@
   }
 
   private def validRace(input: String): Boolean = {
-    (input == "") || inRange(1 to 5, input)
+    (input == "") || inRange(1 to 5, input).getOrElse(false)
   }
 
-  private def inRange(domain: Seq[Int], input: String): Boolean = {
-    try {
-      val x = input.toInt
-      domain.contains(x)
-    } catch {
-      case ex: NumberFormatException => false
-    }
+  private def inRange(domain: Seq[Int], input: String): Try[Boolean] = {
+    Try(domain.contains(input.toInt))
   }
 
   def name: String = "V470"
Handle toInt exception using Try

Previously, the inRange method used a try...catch construction to handle
failures parsing a race value from string to int. That way doesn't take
advantage of Scala's more elegant and idiomatic syntax for trying an
operation that might fail.

Now using Try and getOrElse to simply return false if toInt fails.
